imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add descriptions to ambiguous links for screen readers (#7310)

Browse source 
* add title to room share link

Signed-off-by: Kerry Archibald <kerrya@element.io>

* add ExternalLink component

Signed-off-by: Kerry Archibald <kerrya@element.io>

* unit test ExternalLink

Signed-off-by: Kerry Archibald <kerrya@element.io>

* default target and rel for external link

Signed-off-by: Kerry Archibald <kerrya@element.io>

* use scss $font variables

Signed-off-by: Kerry Archibald <kerrya@element.io>
This commit is contained in:
Kerry 2021-12-09 13:04:06 +01:00 • committed by GitHub
parent d7a6e3ec65
commit 1216285ed2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 160 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

36
test/components/views/elements/__snapshots__/ExternalLink-test.tsx.snap Normal file
View file

@ -0,0 +1,36 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
exports[`<ExternalLink /> renders link correctly 1`] = `
<a
class="mx_ExternalLink myCustomClass"
data-test-id="test"
href="test.com"
rel="noopener"
target="_self"
>
<span>
react element
<b>
children
</b>
</span>
<i
class="mx_ExternalLink_icon"
/>
</a>
`;
exports[`<ExternalLink /> renders plain text link correctly 1`] = `
<a
class="mx_ExternalLink myCustomClass"
data-test-id="test"
href="test.com"
rel="noreferrer noopener"
target="_blank"
>
test
<i
class="mx_ExternalLink_icon"
/>
</a>
`;