imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Stick behind a feature flag

Browse source
This commit is contained in:
Will Hunt 2019-04-21 18:01:26 +01:00
parent 776210c135
commit 0f2cd6ea73
5 changed files with 25 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/Notifier.js
View file

@ -120,11 +120,11 @@ const Notifier = {
};
},
_playAudioNotification: function(ev, room) {
this.getSoundForRoom(room.roomId).then((sound) => {
console.log(`Got sound ${sound.name || "default"} for ${room.roomId}`);
// XXX: How do we ensure this is a sound file and not
// going to be exploited?
_playAudioNotification: async function(ev, room) {
const sound = SettingsStore.isFeatureEnabled("feature_notification_sounds") ? await this.getSoundForRoom(room.roomId) : null;
console.log(`Got sound ${sound.name || "default"} for ${room.roomId}`);
// XXX: How do we ensure this is a sound file and not going to be exploited?
try {
const selector = document.querySelector(sound ? `audio[src='${sound.url}']` : "#messageAudio");
let audioElement = selector;
if (!selector) {
@ -139,9 +139,9 @@ const Notifier = {
document.body.appendChild(audioElement);
}
audioElement.play();
}).catch((ex) => {
} catch (ex) {
console.warn("Caught error when trying to fetch room notification sound:", ex);
});
}
},
start: function() {