imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test UserSettingsDialog (#9118)

Browse source
This commit is contained in:
Kerry 2022-08-01 08:47:13 +02:00 • committed by GitHub
parent 82fb21aff5
commit 05cc5f62dd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 321 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/components/structures/TabbedView.tsx
View file

@ -117,7 +117,12 @@ export default class TabbedView extends React.Component<IProps, IState> {
const label = _t(tab.label);
return (
<AccessibleButton className={classes} key={"tab_label_" + tab.label} onClick={onClickHandler}>
<AccessibleButton
className={classes}
key={"tab_label_" + tab.label}
onClick={onClickHandler}
data-testid={`settings-tab-${tab.id}`}
>
{ tabIcon }
<span className="mx_TabbedView_tabLabel_text">
{ label }

6
src/components/views/dialogs/UserSettingsDialog.tsx
View file

@ -46,7 +46,7 @@ interface IState {
}
export default class UserSettingsDialog extends React.Component<IProps, IState> {
private mjolnirWatcher: string;
private mjolnirWatcher: string | undefined;
constructor(props) {
super(props);
@ -61,7 +61,7 @@ export default class UserSettingsDialog extends React.Component<IProps, IState>
}
public componentWillUnmount(): void {
SettingsStore.unwatchSetting(this.mjolnirWatcher);
this.mjolnirWatcher && SettingsStore.unwatchSetting(this.mjolnirWatcher);
}
private mjolnirChanged: CallbackFn = (settingName, roomId, atLevel, newValue) => {
@ -70,7 +70,7 @@ export default class UserSettingsDialog extends React.Component<IProps, IState>
};
private getTabs() {
const tabs = [];
const tabs: Tab[] = [];
tabs.push(new Tab(
UserTab.General,