imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Move error handling to separate effect

Browse source
This commit is contained in:
Johannes Marbach 2023-02-10 08:25:59 +01:00
parent f842e319de
commit 039824c0ee
2 changed files with 9 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/components/views/location/Map.tsx
View file

@ -106,10 +106,6 @@ const useMapWithStyle = ({
}); });
setGeolocate(geolocate); setGeolocate(geolocate);
map.addControl(geolocate); map.addControl(geolocate);
geolocate.on("error", onGeolocateError);
return () => {
geolocate.off("error", onGeolocateError);
};
} }
if (!allowGeolocate && geolocate) { if (!allowGeolocate && geolocate) {
map.removeControl(geolocate); map.removeControl(geolocate);
@ -117,6 +113,15 @@ const useMapWithStyle = ({
} }
}, [map, geolocate, allowGeolocate]); }, [map, geolocate, allowGeolocate]);
useEffect(() => {
if (geolocate) {
geolocate.on("error", onGeolocateError);
return () => {
geolocate.off("error", onGeolocateError);
};
}
}, [geolocate]);
return { return {
map, map,
bodyId, bodyId,

24
test/components/structures/__snapshots__/PictureInPictureDragger-test.tsx.snap
View file

@ -30,27 +30,3 @@ exports[`PictureInPictureDragger when rendering the dragger with PiP content 1 a
</aside> </aside>
</div> </div>
`; `;
exports[`PictureInPictureDragger when rendering the dragger with PiP content 1 and rerendering PiP content 1 should not change the PiP content: pip-content-1 1`] = `
<div>
<aside
style="transform: translateX(680px) translateY(478px);"
>
<div>
content 1
</div>
</aside>
</div>
`;
exports[`PictureInPictureDragger when rendering the dragger with PiP content 1 should render the PiP content: pip-content-1 1`] = `
<div>
<aside
style="transform: translateX(680px) translateY(478px);"
>
<div>
content 1
</div>
</aside>
</div>
`;