Enable @typescript-eslint/explicit-function-return-type in /src (#9788)

* Enable `@typescript-eslint/explicit-member-accessibility` on /src

* Prettier

* Enable `@typescript-eslint/explicit-function-return-type` in /src

* Fix types

* tsc strict fixes

* Delint

* Fix test

* Fix bad merge
This commit is contained in:
Michael Telatynski 2023-01-12 13:25:14 +00:00 committed by GitHub
parent 7a36ba0fde
commit 030b7e90bf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
683 changed files with 3459 additions and 3013 deletions

View file

@ -45,12 +45,12 @@ export default class AccountSettingsHandler extends MatrixClientBackedSettingsHa
return SettingLevel.ACCOUNT;
}
public initMatrixClient(oldClient: MatrixClient, newClient: MatrixClient) {
public initMatrixClient(oldClient: MatrixClient, newClient: MatrixClient): void {
oldClient?.removeListener(ClientEvent.AccountData, this.onAccountData);
newClient.on(ClientEvent.AccountData, this.onAccountData);
}
private onAccountData = (event: MatrixEvent, prevEvent: MatrixEvent) => {
private onAccountData = (event: MatrixEvent, prevEvent: MatrixEvent): void => {
if (event.getType() === "org.matrix.preview_urls") {
let val = event.getContent()["disable"];
if (typeof val !== "boolean") {
@ -168,7 +168,7 @@ export default class AccountSettingsHandler extends MatrixClientBackedSettingsHa
// Attach a deferred *before* setting the account data to ensure we catch any requests
// which race between different lines.
const deferred = defer<void>();
const handler = (event: MatrixEvent) => {
const handler = (event: MatrixEvent): void => {
if (event.getType() !== eventType || event.getContent()[field] !== value) return;
this.client.off(ClientEvent.AccountData, handler);
deferred.resolve();
@ -229,7 +229,7 @@ export default class AccountSettingsHandler extends MatrixClientBackedSettingsHa
return objectClone(event.getContent()); // clone to prevent mutation
}
private notifyBreadcrumbsUpdate(event: MatrixEvent) {
private notifyBreadcrumbsUpdate(event: MatrixEvent): void {
let val = [];
if (event.getType() === BREADCRUMBS_LEGACY_EVENT_TYPE) {
// This seems fishy - try and get the event for the new rooms