imterah/element-portable
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Enable @typescript-eslint/explicit-function-return-type in /src (#9788)

Browse source 
* Enable `@typescript-eslint/explicit-member-accessibility` on /src

* Prettier

* Enable `@typescript-eslint/explicit-function-return-type` in /src

* Fix types

* tsc strict fixes

* Delint

* Fix test

* Fix bad merge
This commit is contained in:
Michael Telatynski 2023-01-12 13:25:14 +00:00 • committed by GitHub
parent 7a36ba0fde
commit 030b7e90bf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
683 changed files with 3459 additions and 3013 deletions
Download patch file Download diff file Expand all files Collapse all files

30
src/components/views/dialogs/security/AccessSecretStorageDialog.tsx
View file

@ -77,24 +77,24 @@ export default class AccessSecretStorageDialog extends React.PureComponent<IProp
};
}
private onCancel = () => {
private onCancel = (): void => {
if (this.state.resetting) {
this.setState({ resetting: false });
}
this.props.onFinished(false);
};
private onUseRecoveryKeyClick = () => {
private onUseRecoveryKeyClick = (): void => {
this.setState({
forceRecoveryKey: true,
});
};
private validateRecoveryKeyOnChange = debounce(async () => {
private validateRecoveryKeyOnChange = debounce(async (): Promise<void> => {
await this.validateRecoveryKey();
}, VALIDATION_THROTTLE_MS);
private async validateRecoveryKey() {
private async validateRecoveryKey(): Promise<void> {
if (this.state.recoveryKey === "") {
this.setState({
recoveryKeyValid: null,
@ -119,7 +119,7 @@ export default class AccessSecretStorageDialog extends React.PureComponent<IProp
}
}
private onRecoveryKeyChange = (ev: ChangeEvent<HTMLInputElement>) => {
private onRecoveryKeyChange = (ev: ChangeEvent<HTMLInputElement>): void => {
this.setState({
recoveryKey: ev.target.value,
recoveryKeyFileError: null,
@ -136,7 +136,7 @@ export default class AccessSecretStorageDialog extends React.PureComponent<IProp
this.validateRecoveryKeyOnChange();
};
private onRecoveryKeyFileChange = async (ev: ChangeEvent<HTMLInputElement>) => {
private onRecoveryKeyFileChange = async (ev: ChangeEvent<HTMLInputElement>): Promise<void> => {
if (ev.target.files.length === 0) return;
const f = ev.target.files[0];
@ -169,11 +169,11 @@ export default class AccessSecretStorageDialog extends React.PureComponent<IProp
}
};
private onRecoveryKeyFileUploadClick = () => {
private onRecoveryKeyFileUploadClick = (): void => {
this.fileUpload.current.click();
};
private onPassPhraseNext = async (ev: FormEvent<HTMLFormElement> | React.MouseEvent) => {
private onPassPhraseNext = async (ev: FormEvent<HTMLFormElement> | React.MouseEvent): Promise<void> => {
ev.preventDefault();
if (this.state.passPhrase.length <= 0) return;
@ -188,7 +188,7 @@ export default class AccessSecretStorageDialog extends React.PureComponent<IProp
}
};
private onRecoveryKeyNext = async (ev: FormEvent<HTMLFormElement> | React.MouseEvent) => {
private onRecoveryKeyNext = async (ev: FormEvent<HTMLFormElement> | React.MouseEvent): Promise<void> => {
ev.preventDefault();
if (!this.state.recoveryKeyValid) return;
@ -203,19 +203,19 @@ export default class AccessSecretStorageDialog extends React.PureComponent<IProp
}
};
private onPassPhraseChange = (ev: ChangeEvent<HTMLInputElement>) => {
private onPassPhraseChange = (ev: ChangeEvent<HTMLInputElement>): void => {
this.setState({
passPhrase: ev.target.value,
keyMatches: null,
});
};
private onResetAllClick = (ev: React.MouseEvent<HTMLAnchorElement>) => {
private onResetAllClick = (ev: React.MouseEvent<HTMLAnchorElement>): void => {
ev.preventDefault();
this.setState({ resetting: true });
};
private onConfirmResetAllClick = async () => {
private onConfirmResetAllClick = async (): Promise<void> => {
// Hide ourselves so the user can interact with the reset dialogs.
// We don't conclude the promise chain (onFinished) yet to avoid confusing
// any upstream code flows.
@ -226,11 +226,11 @@ export default class AccessSecretStorageDialog extends React.PureComponent<IProp
try {
// Force reset secret storage (which resets the key backup)
await accessSecretStorage(async () => {
await accessSecretStorage(async (): Promise<void> => {
// Now reset cross-signing so everything Just Works™ again.
const cli = MatrixClientPeg.get();
await cli.bootstrapCrossSigning({
authUploadDeviceSigningKeys: async (makeRequest) => {
authUploadDeviceSigningKeys: async (makeRequest): Promise<void> => {
const { finished } = Modal.createDialog(InteractiveAuthDialog, {
title: _t("Setting up keys"),
matrixClient: cli,
@ -268,7 +268,7 @@ export default class AccessSecretStorageDialog extends React.PureComponent<IProp
}
}
public render() {
public render(): JSX.Element {
const hasPassphrase =
this.props.keyInfo &&
this.props.keyInfo.passphrase &&

2
src/components/views/dialogs/security/ConfirmDestroyCrossSigningDialog.tsx
View file

@ -33,7 +33,7 @@ export default class ConfirmDestroyCrossSigningDialog extends React.Component<IP
this.props.onFinished(false);
};
public render() {
public render(): JSX.Element {
return (
<BaseDialog
className="mx_ConfirmDestroyCrossSigningDialog"

2
src/components/views/dialogs/security/CreateCrossSigningDialog.tsx
View file

@ -167,7 +167,7 @@ export default class CreateCrossSigningDialog extends React.PureComponent<IProps
this.props.onFinished(false);
};
public render() {
public render(): JSX.Element {
let content;
if (this.state.error) {
content = (

4
src/components/views/dialogs/security/RestoreKeyBackupDialog.tsx
View file

@ -125,7 +125,7 @@ export default class RestoreKeyBackupDialog extends React.PureComponent<IProps,
private onResetRecoveryClick = (): void => {
this.props.onFinished(false);
accessSecretStorage(async () => {}, /* forceReset = */ true);
accessSecretStorage(async (): Promise<void> => {}, /* forceReset = */ true);
};
private onRecoveryKeyChange = (e): void => {
@ -227,7 +227,7 @@ export default class RestoreKeyBackupDialog extends React.PureComponent<IProps,
});
try {
// `accessSecretStorage` may prompt for storage access as needed.
await accessSecretStorage(async () => {
await accessSecretStorage(async (): Promise<void> => {
await MatrixClientPeg.get().restoreKeyBackupWithSecretStorage(
this.state.backupInfo,
undefined,

8
src/components/views/dialogs/security/SetupEncryptionDialog.tsx
View file

@ -22,7 +22,7 @@ import { _t } from "../../../../languageHandler";
import { SetupEncryptionStore, Phase } from "../../../../stores/SetupEncryptionStore";
import { IDialogProps } from "../IDialogProps";
function iconFromPhase(phase: Phase) {
function iconFromPhase(phase: Phase): string {
if (phase === Phase.Done) {
return require("../../../../../res/img/e2e/verified-deprecated.svg").default;
} else {
@ -45,11 +45,11 @@ export default class SetupEncryptionDialog extends React.Component<IProps, IStat
this.state = { icon: iconFromPhase(this.store.phase) };
}
public componentDidMount() {
public componentDidMount(): void {
this.store.on("update", this.onStoreUpdate);
}
public componentWillUnmount() {
public componentWillUnmount(): void {
this.store.removeListener("update", this.onStoreUpdate);
}
@ -57,7 +57,7 @@ export default class SetupEncryptionDialog extends React.Component<IProps, IStat
this.setState({ icon: iconFromPhase(this.store.phase) });
};
public render() {
public render(): JSX.Element {
return (
<BaseDialog
headerImage={this.state.icon}