diff --git a/src/components/views/groups/GroupPublicityToggle.js b/src/components/views/groups/GroupPublicityToggle.js
index e27bf9a9d5..98fa598e20 100644
--- a/src/components/views/groups/GroupPublicityToggle.js
+++ b/src/components/views/groups/GroupPublicityToggle.js
@@ -68,7 +68,9 @@ export default React.createClass({
render() {
const GroupTile = sdk.getComponent('groups.GroupTile');
return
-
+
diff --git a/src/components/views/groups/GroupTile.js b/src/components/views/groups/GroupTile.js
index 509c209baa..18ef5a5637 100644
--- a/src/components/views/groups/GroupTile.js
+++ b/src/components/views/groups/GroupTile.js
@@ -33,6 +33,7 @@ const GroupTile = React.createClass({
showDescription: PropTypes.bool,
// Height of the group avatar in pixels
avatarHeight: PropTypes.number,
+ draggable: PropTypes.bool,
},
contextTypes: {
@@ -49,6 +50,7 @@ const GroupTile = React.createClass({
return {
showDescription: true,
avatarHeight: 50,
+ draggable: true,
};
},
@@ -78,54 +80,54 @@ const GroupTile = React.createClass({
{ profile.shortDescription }
:
;
const httpUrl = profile.avatarUrl ? this.context.matrixClient.mxcUrlToHttp(
- profile.avatarUrl, avatarHeight, avatarHeight, "crop",
- ) : null;
+ profile.avatarUrl, avatarHeight, avatarHeight, "crop") : null;
+
+ let avatarElement = (
+
+
+
+ );
+ if (this.props.draggable) {
+ const avatarClone = avatarElement;
+ avatarElement = (
+
+ { (droppableProvided, droppableSnapshot) => (
+
+
+ { (provided, snapshot) => (
+
+
+ {avatarClone}
+
+ { /* Instead of a blank placeholder, use a copy of the avatar itself. */ }
+ { provided.placeholder ? avatarClone :
}
+
+ ) }
+
+
+ ) }
+
+ );
+ }
+
// XXX: Use onMouseDown as a workaround for https://github.com/atlassian/react-beautiful-dnd/issues/273
// instead of onClick. Otherwise we experience https://github.com/vector-im/riot-web/issues/6156
return
-
- { (droppableProvided, droppableSnapshot) => (
-
-
- { (provided, snapshot) => (
-
-
- { /* Instead of a blank placeholder, use a copy of the avatar itself. */ }
- { provided.placeholder ?
-
-
-
:
-
- }
-
- ) }
-
-
- ) }
-
+ { avatarElement }
{ name }
{ descElement }
diff --git a/src/components/views/settings/tabs/user/FlairUserSettingsTab.js b/src/components/views/settings/tabs/user/FlairUserSettingsTab.js
index 0daa20b8b3..0063a9a981 100644
--- a/src/components/views/settings/tabs/user/FlairUserSettingsTab.js
+++ b/src/components/views/settings/tabs/user/FlairUserSettingsTab.js
@@ -16,7 +16,6 @@ limitations under the License.
import React from 'react';
import {_t} from "../../../../../languageHandler";
-import {DragDropContext} from "react-beautiful-dnd";
import GroupUserSettings from "../../../groups/GroupUserSettings";
import MatrixClientPeg from "../../../../../MatrixClientPeg";
import PropTypes from "prop-types";
@@ -42,9 +41,7 @@ export default class FlairUserSettingsTab extends React.Component {
);