From e8a8d544c594b81b778c1e1258173837de61b001 Mon Sep 17 00:00:00 2001 From: raysan5 Date: Mon, 30 Mar 2020 14:38:16 +0200 Subject: [PATCH] Review formating and signegness issues --- src/core.c | 20 ++++++++++---------- src/text.c | 2 +- src/textures.c | 6 +++--- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/core.c b/src/core.c index 11106eac1..b3010ce4d 100644 --- a/src/core.c +++ b/src/core.c @@ -16,7 +16,7 @@ * * #define PLATFORM_DESKTOP * Windowing and input system configured for desktop platforms: Windows, Linux, OSX, FreeBSD, OpenBSD, NetBSD, DragonFly -* NOTE: Oculus Ritf CV1 requires PLATFORM_DESKTOP for mirror rendering - View [rlgl] module to enable it +* NOTE: Oculus Rift CV1 requires PLATFORM_DESKTOP for mirror rendering - View [rlgl] module to enable it * * #define PLATFORM_ANDROID * Windowing and input system configured for Android device, app activity managed internally in this module. @@ -2226,19 +2226,18 @@ void SaveStorageValue(unsigned int position, int value) else { // RL_REALLOC failed - TRACELOG(LOG_WARNING, "FILEIO: Position in bytes (%u) bigger than actual size of file [%s] (%u) Realloc function FAIL",position*sizeof(int),path,dataSize); + TRACELOG(LOG_WARNING, "FILEIO: [%s] Failed to realloc data (%u), position in bytes (%u) bigger than actual file size", path, dataSize, position*sizeof(int)); - // We store the old size of the file. - newFileData=fileData; - newDataSize=dataSize; + // We store the old size of the file + newFileData = fileData; + newDataSize = dataSize; } - } else { - // We store the old size of the file. - newFileData=fileData; - newDataSize=dataSize; + // Store the old size of the file + newFileData = fileData; + newDataSize = dataSize; // Replace value on selected position int *dataPtr = (int *)newFileData; @@ -2250,7 +2249,8 @@ void SaveStorageValue(unsigned int position, int value) } else { - TRACELOG(LOG_INFO, "FILEIO: [%s] File not found, creating it.",path); + TRACELOG(LOG_INFO, "FILEIO: [%s] File not found, creating it", path); + dataSize = (position + 1)*sizeof(int); fileData = (unsigned char *)RL_MALLOC(dataSize); int *dataPtr = (int *)fileData; diff --git a/src/text.c b/src/text.c index 781d3c820..f83eed888 100644 --- a/src/text.c +++ b/src/text.c @@ -495,7 +495,7 @@ CharInfo *LoadFontData(const char *fileName, int fontSize, int *fontChars, int c // Load font data (including pixel data) from TTF file // NOTE: Loaded information should be enough to generate // font image atlas, using any packaging method - int dataSize = 0; + unsigned int dataSize = 0; unsigned char *fileData = LoadFileData(fileName, &dataSize); if (fileData != NULL) diff --git a/src/textures.c b/src/textures.c index ae025af94..11dcc8875 100644 --- a/src/textures.c +++ b/src/textures.c @@ -235,7 +235,7 @@ Image LoadImage(const char *fileName) #if defined(STBI_REQUIRED) // NOTE: Using stb_image to load images (Supports multiple image formats) - int dataSize = 0; + unsigned int dataSize = 0; unsigned char *fileData = LoadFileData(fileName, &dataSize); if (fileData != NULL) @@ -354,7 +354,7 @@ Image LoadImageRaw(const char *fileName, int width, int height, int format, int { Image image = { 0 }; - int dataSize = 0; + unsigned int dataSize = 0; unsigned char *fileData = LoadFileData(fileName, &dataSize); if (fileData != NULL) @@ -3059,7 +3059,7 @@ static Image LoadAnimatedGIF(const char *fileName, int *frames, int **delays) { Image image = { 0 }; - int dataSize = 0; + unsigned int dataSize = 0; unsigned char *fileData = LoadFileData(fileName, &dataSize); if (fileData != NULL)