Better default values for normals and tangents (VBOs) (#4763)

This commit is contained in:
Le Juez Victor 2025-02-14 01:00:05 +01:00 committed by GitHub
parent ee946b2f16
commit c647d33703
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -1307,7 +1307,7 @@ void UploadMesh(Mesh *mesh, bool dynamic)
{ {
// Default vertex attribute: normal // Default vertex attribute: normal
// WARNING: Default value provided to shader if location available // WARNING: Default value provided to shader if location available
float value[3] = { 1.0f, 1.0f, 1.0f }; float value[3] = { 0.0f, 0.0f, 1.0f };
rlSetVertexAttributeDefault(RL_DEFAULT_SHADER_ATTRIB_LOCATION_NORMAL, value, SHADER_ATTRIB_VEC3, 3); rlSetVertexAttributeDefault(RL_DEFAULT_SHADER_ATTRIB_LOCATION_NORMAL, value, SHADER_ATTRIB_VEC3, 3);
rlDisableVertexAttribute(RL_DEFAULT_SHADER_ATTRIB_LOCATION_NORMAL); rlDisableVertexAttribute(RL_DEFAULT_SHADER_ATTRIB_LOCATION_NORMAL);
} }
@ -1339,7 +1339,7 @@ void UploadMesh(Mesh *mesh, bool dynamic)
{ {
// Default vertex attribute: tangent // Default vertex attribute: tangent
// WARNING: Default value provided to shader if location available // WARNING: Default value provided to shader if location available
float value[4] = { 0.0f, 0.0f, 0.0f, 0.0f }; float value[4] = { 1.0f, 0.0f, 0.0f, 1.0f };
rlSetVertexAttributeDefault(RL_DEFAULT_SHADER_ATTRIB_LOCATION_TANGENT, value, SHADER_ATTRIB_VEC4, 4); rlSetVertexAttributeDefault(RL_DEFAULT_SHADER_ATTRIB_LOCATION_TANGENT, value, SHADER_ATTRIB_VEC4, 4);
rlDisableVertexAttribute(RL_DEFAULT_SHADER_ATTRIB_LOCATION_TANGENT); rlDisableVertexAttribute(RL_DEFAULT_SHADER_ATTRIB_LOCATION_TANGENT);
} }