UnrealXR/raylib
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

simplify QuaternionInvert (#2324)

Browse source
This commit is contained in:
megagrump 2022-01-31 09:39:21 +01:00 • committed by GitHub
parent 680cc72d43
commit c54d9cd552
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/raymath.h
View file

@ -282,7 +282,7 @@ RMAPI float Vector2Distance(Vector2 v1, Vector2 v2)
RMAPI float Vector2Angle(Vector2 v1, Vector2 v2) RMAPI float Vector2Angle(Vector2 v1, Vector2 v2)
{ {
float result = atan2f(v2.y, v2.x) - atan2f(v1.y, v1.x); float result = atan2f(v2.y, v2.x) - atan2f(v1.y, v1.x);
return result; return result;
} }
@ -549,12 +549,12 @@ RMAPI float Vector3Distance(Vector3 v1, Vector3 v2)
RMAPI float Vector3Angle(Vector3 v1, Vector3 v2) RMAPI float Vector3Angle(Vector3 v1, Vector3 v2)
{ {
float result = 0.0f; float result = 0.0f;
Vector3 cross = { v1.y*v2.z - v1.z*v2.y, v1.z*v2.x - v1.x*v2.z, v1.x*v2.y - v1.y*v2.x }; Vector3 cross = { v1.y*v2.z - v1.z*v2.y, v1.z*v2.x - v1.x*v2.z, v1.x*v2.y - v1.y*v2.x };
float len = sqrtf(cross.x*cross.x + cross.y*cross.y + cross.z*cross.z); float len = sqrtf(cross.x*cross.x + cross.y*cross.y + cross.z*cross.z);
float dot = (v1.x*v2.x + v1.y*v2.y + v1.z*v2.z); float dot = (v1.x*v2.x + v1.y*v2.y + v1.z*v2.z);
result = atan2f(len, dot); result = atan2f(len, dot);
return result; return result;
} }
@ -1490,8 +1490,7 @@ RMAPI Quaternion QuaternionInvert(Quaternion q)
{ {
Quaternion result = q; Quaternion result = q;
float length = sqrtf(q.x*q.x + q.y*q.y + q.z*q.z + q.w*q.w); float lengthSq = q.x*q.x + q.y*q.y + q.z*q.z + q.w*q.w;
float lengthSq = length*length;
if (lengthSq != 0.0) if (lengthSq != 0.0)
{ {