UnrealXR/raylib
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[parser] MemoryCopy() calls: Prevent buffer overflow by replacing hard-coded arguments (#4011)

Browse source 
In future, if a dev edits the second arg and miscalulates the corresponding 3rd arg, there will be a buffer overflow or the string (2nd arg) will be cut short. This commit prevents that.
This commit is contained in:
avx0 2024-05-29 15:00:28 +05:30 • committed by GitHub
parent 785ec74b92
commit 9cc7e3528f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

15
parser/raylib_parser.c
View file

@ -202,9 +202,12 @@ int main(int argc, char* argv[])
{ {
if (argc > 1) ProcessCommandLine(argc, argv); if (argc > 1) ProcessCommandLine(argc, argv);
if (inFileName[0] == '\0') MemoryCopy(inFileName, "../src/raylib.h\0", 16); const char *raylibhPath = "../src/raylib.h\0";
if (outFileName[0] == '\0') MemoryCopy(outFileName, "raylib_api.txt\0", 15); const char *raylibapiPath = "raylib_api.txt\0";
if (apiDefine[0] == '\0') MemoryCopy(apiDefine, "RLAPI\0", 6); const char *rlapiPath = "RLAPI\0";
if (inFileName[0] == '\0') MemoryCopy(inFileName, raylibhPath, TextLength(raylibhPath) + 1);
if (outFileName[0] == '\0') MemoryCopy(outFileName, raylibapiPath, TextLength(raylibapiPath) + 1);
if (apiDefine[0] == '\0') MemoryCopy(apiDefine, rlapiPath, TextLength(rlapiPath) + 1);
int length = 0; int length = 0;
char *buffer = LoadFileText(inFileName, &length); char *buffer = LoadFileText(inFileName, &length);
@ -1277,8 +1280,10 @@ static void GetDataTypeAndName(const char *typeName, int typeNameLen, char *type
} }
else if ((typeName[k] == '.') && (typeNameLen == 3)) // Handle varargs ...); else if ((typeName[k] == '.') && (typeNameLen == 3)) // Handle varargs ...);
{ {
MemoryCopy(type, "...", 3); const char *varargsDots = "...";
MemoryCopy(name, "args", 4); const char *varargsArg = "args";
MemoryCopy(type, varargsDots, TextLength(varargsDots));
MemoryCopy(name, varargsArg, TextLength(varargsArg));
break; break;
} }
} }