From 4d209d45aaf65c9a957a41ba57a19496cb9d9364 Mon Sep 17 00:00:00 2001 From: Ahmad Fatoum Date: Sun, 29 Jul 2018 07:51:17 +0200 Subject: [PATCH] core: Don't use GLFW_TRANSPARENT_FRAMEBUFFER with older GLFWs PLATFORM_WEB is not the only platform that doesn't define GLFW_TRANSPARENT_FRAMEBUFFER, it's also recent enough that it's not included in the most recent GLFW 3.2.1 release, so this error can creep up when using USE_EXTERNAL_GLFW. --- src/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/core.c b/src/core.c index 6939b844b..aa76e88cd 100644 --- a/src/core.c +++ b/src/core.c @@ -1915,14 +1915,14 @@ static bool InitGraphicsDevice(int width, int height) if (configFlags & FLAG_WINDOW_UNDECORATED) glfwWindowHint(GLFW_DECORATED, GL_FALSE); // Border and buttons on Window else glfwWindowHint(GLFW_DECORATED, GL_TRUE); // Decorated window - -#if !defined(PLATFORM_WEB) // FLAG_WINDOW_TRANSPARENT not supported on HTML5 + // FLAG_WINDOW_TRANSPARENT not supported on HTML5 and not included in any released GLFW version yet +#if defined(GLFW_TRANSPARENT_FRAMEBUFFER) if (configFlags & FLAG_WINDOW_TRANSPARENT) glfwWindowHint(GLFW_TRANSPARENT_FRAMEBUFFER, GLFW_TRUE); // Transparent framebuffer else glfwWindowHint(GLFW_TRANSPARENT_FRAMEBUFFER, GLFW_FALSE); // Opaque framebuffer #endif if (configFlags & FLAG_MSAA_4X_HINT) glfwWindowHint(GLFW_SAMPLES, 4); // Tries to enable multisampling x4 (MSAA), default is 0 - + // NOTE: When asking for an OpenGL context version, most drivers provide highest supported version // with forward compatibility to older OpenGL versions. // For example, if using OpenGL 1.1, driver can provide a 4.3 context forward compatible.