Fix lgtm warnings (#2477)

* Comparison is always true because finalSample >= 1

* Comparison is always false because keyCount >= 0
This commit is contained in:
Crydsch 2022-05-14 15:02:29 +02:00 committed by GitHub
parent db16833d8c
commit 020e903193
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 4 deletions

View file

@ -1999,7 +1999,6 @@ bool GuiTextBox(Rectangle bounds, char *text, int textSize, bool editMode)
{ {
keyCount--; keyCount--;
text[keyCount] = '\0'; text[keyCount] = '\0';
if (keyCount < 0) keyCount = 0;
} }
} }
@ -2177,7 +2176,6 @@ bool GuiValueBox(Rectangle bounds, const char *text, int *value, int minValue, i
{ {
keyCount--; keyCount--;
textValue[keyCount] = '\0'; textValue[keyCount] = '\0';
if (keyCount < 0) keyCount = 0;
valueHasChanged = true; valueHasChanged = true;
} }
} }

View file

@ -1206,8 +1206,7 @@ Wave WaveCopy(Wave wave)
// NOTE: Security check in case of out-of-range // NOTE: Security check in case of out-of-range
void WaveCrop(Wave *wave, int initSample, int finalSample) void WaveCrop(Wave *wave, int initSample, int finalSample)
{ {
if ((initSample >= 0) && (initSample < finalSample) && if ((initSample >= 0) && (initSample < finalSample) && ((unsigned int)finalSample < (wave->frameCount*wave->channels)))
(finalSample > 0) && ((unsigned int)finalSample < (wave->frameCount*wave->channels)))
{ {
int sampleCount = finalSample - initSample; int sampleCount = finalSample - initSample;